[BEE-37070] add inline documentation for build strategies#388
[BEE-37070] add inline documentation for build strategies#388ampuscas wants to merge 3 commits intojenkinsci:masterfrom
Conversation
| <f:entry title="${%Build strategies}" field="buildStrategies"> | ||
| <f:entry title="${%Strategy}" field="strategyId"></f:entry> | ||
| <f:hetero-list name="buildStrategies" items="${instance.buildStrategies}" |
There was a problem hiding this comment.
The fake f:entry does not look right. You should not need to resort to tricks to have help for a standard form control. I think the problem here is that the original page used unnecessarily low-level controls. Better to use the higher-level f:repeatableHeteroProperty which groks databinding and should allow you to simply create a file with the conventional name, help-buildStrategies.html.
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Sort of works. Gets messed up when you click the help next to an actual strategy like Skip initial build on first branch indexing, which I suspect is due to this facet still using a nonstandard control.
| <j:set var="descriptors" value="${descriptor.buildStrategiesDescriptors(it,sourceDescriptor)}"/> | ||
| <j:if test="${!descriptors.isEmpty()}"> | ||
| <f:entry title="${%Build strategies}"> | ||
| <f:entry title="${%Build strategies}" field="buildStrategies"> |
There was a problem hiding this comment.
So, showing
|
Might not be possible to use branch-api-plugin/src/main/java/jenkins/branch/BranchSource.java Lines 177 to 178 in 09cb8ea |
2 participants
Add inline documentation for Build Strategies
Testing done